Fix: Syntax in discussion tree #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubbortlik
force-pushed
the
fix-syntax-in-discussion-tree
branch
from
2fce01c to
40bedf7
Compare
Owner
|
Hey @jakubbortlik I've merged in some changes to shorten the winbar, so this will need another look when you have a moment to resolve that conflict. |
jakubbortlik
force-pushed
the
fix-syntax-in-discussion-tree
branch
from
40bedf7 to
b9aa637
Compare
Collaborator
Author
Hi Harrison, thanks for taking care of all the recent PRs! I really appreciate that you merged them in (or came up with alternatives like for the winbar shortening). This one should now also be ready for merge. The syntax highlighting is now only applied in the header of a node, unless somebody copies the text of the header and pastes it into the message 😄 |
harrisoncramer
added a commit
that referenced
this pull request
Dec 11, 2024
* Feat: Enable sorting discussions by original comment (#422) * Feat: Improve popup UX (#426) * Feat: Automatically update MR summary details (#427) * Feat: Show update progress in winbar (#432) * Feat: Abbreviate winbar (#439) * Fix: Note Creation Bug (#441) * Fix: Checking whether comment can be created (#434) * Fix: Syntax in discussion tree (#433) * fix: improve indication of resolved threads and drafts (#442) * Docs: Various minor improvements (#445) --------- Co-authored-by: Jakub F. Bortlík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @harrisoncramer, this is partly a follow-up PR to #432, since that PR changes the what
utils.time_since()returns for times less than a minute, and this PR addsjust nowto the strings matched asdatein thegitlabfiletype syntax.While I was touching the syntax file, I also fixed it so that the note header components (expanders, note creation time, (un)resolved symbols and the draft symbol) are only matched within the header, but not in the note body (before, even strings like "5 minutes agony" would be highlighted as time :)