-
Notifications
You must be signed in to change notification settings - Fork 49
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Prerequsities
- I'm on the latest version of the plugin
- I've installed the required dependencies
- I've run
:h gitlab.nvim.troubleshootingand followed the steps there
Bug Description
When a file with a comment is renamed/moved, the jump_to_reviewer action in the discussion tree jumps to the last selected file instead which can be confusing for users.
Reproduction Steps
- Check out the feature branch
- Open Neovim
- Start
gitlab.nvimreview - Make a comment on a line
- Rename the file with the comment,
git add & commit & push - Local the comment in the discussion tree and press the
Jump to reviewerkeybinding.
Possible fix
This is easy to fix by checking whether a file has been selected in gitlab.nvim/lua/gitlab/reviewer/init.lua line 120-122. If not, show a warning and do not jump to the reviewer. I've got this working in a feature branch, so I can prepare a PR.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working