Removes backup register option (#242)

This MR deprecates the "backup" register which was a hot-fix used to deal with bugs upon comment and note creation

Author: harrisoncramer

README.md

@@ -127,7 +127,6 @@ require("gitlab").setup({
     pipeline = nil,
     reply = nil,
     squash_message = nil,
-    backup_register = nil,
   },
   discussion_tree = { -- The discussion tree that holds all comments
     auto_open = true, -- Automatically open when the reviewer is opened

doc/gitlab.nvim.txt

@@ -158,7 +158,6 @@ you call this function with no values the defaults will be used:
         pipeline = nil,
         reply = nil,
         squash_message = nil,
-        backup_register = nil,
       },
       discussion_tree = { -- The discussion tree that holds all comments
         auto_open = true, -- Automatically open when the reviewer is opened
@@ -304,22 +303,6 @@ code block with prefilled code from the visual selection.
 Just like the summary, all the different kinds of comments are saved via the
 `settings.popup.perform_action` keybinding.
 
-BACKUP REGISTER                                  *gitlab.nvim.backup-register*
-
-Sometimes, the action triggered by `settings.popup.perform_action` can fail.
-To prevent losing your carefully crafted note/comment/suggestion you can set
-`settings.popup.backup_register` to a writable register (see |registers|) to
-which the contents of the popup window will be saved just before the action is
-performed. A practical setting is `settings.popup.backup_register = "+"` which
-saves to the system clipboard (see |quoteplus|). This lets you easily apply
-the action on Gitlab in a browser, if it keeps failing in `gitlab.nvim`.
-
-If you experience such problems, please first read the
-|gitlab.nvim.troubleshooting| section. If it does not help, see if there are
-any relevant known <https://github.com/harrisoncramer/gitlab.nvim/issues>. If
-there are none, please open one and provide any error messages that
-`gitlab.nvim` may be showing.
-
 DISCUSSIONS AND NOTES                      *gitlab.nvim.discussions-and-notes*
 
 Gitlab groups threads of comments together into "discussions."

lua/gitlab/state.lua

@@ -39,7 +39,6 @@ M.settings = {
     help = nil,
     pipeline = nil,
     squash_message = nil,
-    backup_register = nil,
   },
   discussion_tree = {
     auto_open = true,
@@ -278,9 +277,6 @@ M.set_popup_keymaps = function(popup, action, linewise_action, opts)
   if action ~= nil then
     vim.keymap.set("n", M.settings.popup.perform_action, function()
       local text = u.get_buffer_text(popup.bufnr)
-      if M.settings.popup.backup_register ~= nil then
-        vim.cmd("0,$yank " .. M.settings.popup.backup_register)
-      end
       if opts.action_before_close then
         action(text, popup.bufnr)
         exit(popup, opts)