fix: remove esc keybinding (#240)

This MR removes the `<esc>` keybinding from the application for popups to avoid accidentally nuking existing changes. Addresses #239.

Author: harrisoncramer

README.md

@@ -115,7 +115,6 @@ require("gitlab").setup({
   },
   help = "g?", -- Opens a help popup for local keymaps when a relevant view is focused (popup, discussion panel, etc)
   popup = { -- The popup for comment creation, editing, and replying
-    exit = "<Esc>",
     perform_action = "<leader>s", -- Once in normal mode, does action (like saving comment or editing description, etc)
     perform_linewise_action = "<leader>l", -- Once in normal mode, does the linewise action (see logs for this job, etc)
     width = "40%",

doc/gitlab.nvim.txt

@@ -146,7 +146,6 @@ you call this function with no values the defaults will be used:
       },
       help = "g?", -- Opens a help popup for local keymaps when a relevant view is focused (popup, discussion panel, etc)
       popup = { -- The popup for comment creation, editing, and replying
-        exit = "<Esc>",
         perform_action = "<leader>s", -- Once in normal mode, does action (like saving comment or editing description, etc)
         perform_linewise_action = "<leader>l", -- Once in normal mode, does the linewise action (see logs for this job, etc)
         width = "40%",

lua/gitlab/actions/create_mr.lua

@@ -196,10 +196,6 @@ M.add_title = function(mr)
       mr.title = value
     end,
   })
-  input:map("n", "<Esc>", function()
-    input:unmount()
-  end, { noremap = true })
-
   input:mount()
 end
 

lua/gitlab/state.lua

@@ -26,7 +26,6 @@ M.settings = {
   attachment_dir = "",
   help = "g?",
   popup = {
-    exit = "<Esc>",
     perform_action = "<leader>s",
     perform_linewise_action = "<leader>l",
     width = "40%",
@@ -270,10 +269,6 @@ M.set_popup_keymaps = function(popup, action, linewise_action, opts)
   if opts == nil then
     opts = {}
   end
-  vim.keymap.set("n", M.settings.popup.exit, function()
-    exit(popup, opts)
-  end, { buffer = popup.bufnr, desc = "Exit popup" })
-
   if action ~= "Help" then -- Don't show help on the help popup
     vim.keymap.set("n", M.settings.help, function()
       local help = require("gitlab.actions.help")
@@ -304,6 +299,13 @@ M.set_popup_keymaps = function(popup, action, linewise_action, opts)
       linewise_action(text)
     end, { buffer = popup.bufnr, desc = "Perform linewise action" })
   end
+
+  vim.api.nvim_create_autocmd("BufUnload", {
+    buffer = popup.bufnr,
+    callback = function()
+      exit(popup, opts)
+    end,
+  })
 end
 
 -- Dependencies