Parse field for day of week should allow 0 or SUN values #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ruizmarc! Thanks for reporting this! It looks like a regression introduced by the latest patch release. Fix looks good, but let's also add test case to verify that it's fixed.
Best regards |
|
Done :) |
harrisiirak
approved these changes
Feb 19, 2025
|
Merged and published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently expressions like:
0 0 3 * * SUNare crashing as SUN is parsed as 0 and when field parser checks for replacer existence, instead of checking explicitly for undefined values to throw an error it is checking for any no truthy expression. 0 is a valid value, but not a truthy. Just checking for explicit undefined values should solve the problem.