Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: Remove output from lint.go #225

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Lint: Remove output from lint.go #225

merged 2 commits into from
Apr 5, 2023

Conversation

dsotirakis
Copy link
Contributor

Currently, when using drone-cli v1.6.1, when running drone lint, we get every iteration line printed in the console.
This could either be a leftover or an intentional print. If it's intentional, then a --debug flag could be added there.

Steps to reproduce:

$ drone-v1.6.1 lint .drone.yml --trusted
2022/11/04 17:43:46 proto: duplicate proto type registered: PluginSpec
2022/11/04 17:43:46 proto: duplicate proto type registered: PluginPrivilege
&{ pipeline docker pr-verify-drone [] {false 0 3 false false} {0} map[type:some-node] {linux amd64  } {{[] []} {[] []} {[] []} {[] []} {[] []} {[] []} {[pull_request] []} {[] []} {[] []} {[scripts/drone/** .drone.yml .drone.star] []}} map[] [] [0xc000120380 0xc000121180 0xc000121500 0xc000121880] [0xc0000ad840] [dockerconfigjson] { }}

@dsotirakis dsotirakis force-pushed the remove-unnecessary-lint-output branch from 8fd4ba1 to 08afee5 Compare November 5, 2022 09:30
@tphoney tphoney added the bug label Apr 5, 2023
@tphoney tphoney merged commit 65934cc into harness:master Apr 5, 2023
@tphoney
Copy link
Contributor

tphoney commented Apr 5, 2023

Merged, thanks for the change !

tphoney pushed a commit to tphoney/drone-cli that referenced this pull request Sep 6, 2023
@tkushnir @eoinmcafee00
@alikhil @jvrplmlmn @Xopherus @julienduchesne @marko-gacesa @MarieReRe @kameshsampath @bradrydzewski @rhiaxion @dsotirakis @dependabot @smjt-h
Multiple pipelines (#1)
d15d694 
* Add missing ctx values

* Add new ctx.build.debug option

* Build drone for mac with m1 chip

* Update go version to support m1 builds

* Update go version in drone.yml

* Update building

* run go mod tidy

* feat(cron): add rm command

Signed-off-by: Javier Palomo <[email protected]>

* Add drone cron exec cmd (harness#180)

* fixes issue were cli required an additional parameter in order to communicate with vault when using drone-vault plugin.

* refactor env variable declaration to one statement

* improve Defect/permission template command (harness#191)

* Update the way namespace is sent to the drone server.
* update drone-go version
* bump drone-go library

* (DRON-113) use ghodss/yaml for yaml pretty print

* release prep v1.3.1

* (fix) re-enable format option for jsonnet command

* (maint) release prep for v1.3.2

* Fix `--stream` combined with `--format` for `jsonnet` (harness#195)

* Fix `--stream` combined with `--format` for `jsonnet`
If both are defined and jsonnet defines a list, it currently only generates one of the resources
Also added a test for it
* Minimize diffs by keeping all in one file

* (maint) release prep v1.3.3

* provide update and get info values for repo

* bump drone-go

* (fix) fix multi-docs/lists in starlark

* (maint) release-v1.4.0 prep

* Update go-jsonnet to version v0.17.0

* fixes issue where template info command wasn't working

* (dron-124) Add new command for build incomplete V2

* Update README.md

* update libaries with vulnerabilies

* release prep v1.5.0

* (feat) remove drone-yaml dependency. use docker compiler for lint

* rewrite of exec command, use docker runner code

* add community information

* (drone-372) use the modern docker runner for exec, upgrade deps

* (fix): add labels for tooling to query containers (harness#218)

* (fix): add labels for tooling to query containers

* fix: use .drone.yml as default pipeline file (harness#219)

use .drone.yml as default pipeline file if no pipeline file is passed

* (maint) v1.6.0 release prep

* (fix) add secret file to compiler in exec

* (maint) update containerd and docker/distrubution

* (maint) release prep 1.6.1 & go tidy (harness#223)

* fix lack of colors in drone exec output

* fix: use right parameter name for secrets-file (harness#226)

Update the param name to secret-file instead of secrets

* (maint) prep v1.6.2

* Add support for jpath in jsonnet (harness#224)

* Add support for jpath in jsonnet
Co-authored-by: TP Honey <[email protected]>

* (maint) v1.7.0 prep

* Remove output for resources (harness#225)

* Bump google.golang.org/grpc from 1.43.0 to 1.53.0

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.43.0...v1.53.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump github.com/docker/distribution

Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.1+incompatible to 2.8.2+incompatible.
- [Release notes](https://github.com/docker/distribution/releases)
- [Commits](distribution/distribution@v2.8.1...v2.8.2)

---
updated-dependencies:
- dependency-name: github.com/docker/distribution
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump github.com/containerd/containerd from 1.6.8 to 1.6.18

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.6.8 to 1.6.18.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](containerd/containerd@v1.6.8...v1.6.18)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump golang.org/x/net from 0.0.0-20220630215102-69896b714898 to 0.7.0

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20220630215102-69896b714898 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/commits/v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: [CI-8942]: Add manifest push support (harness#235)

* fix: [CI-8942]: Add manifest push support

---------

Co-authored-by: TP Honey <[email protected]>

* (fix) setup dependencies in drone build

* (fix) add manifest file

* Update .drone.yml

* Update manifest.tmpl

* Update .drone.yml

* Update .drone.yml

* Update manifest.tmpl

* Update manifest.tmpl

* Update .drone.yml set platform for arm64

* [feat]: [CI-8942]: Add alpine support (harness#240)

* [feat]: [CI-8942]: Add alpine support

---------

Co-authored-by: TP Honey <[email protected]>

* fix arm (harness#241)

* switch to vm runner

* parallelize build and use native infra

---------

Signed-off-by: Javier Palomo <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Timofei Kushnir <[email protected]>
Co-authored-by: Eoin McAfee <[email protected]>
Co-authored-by: Alik Khilazhev <[email protected]>
Co-authored-by: Javier Palomo <[email protected]>
Co-authored-by: Chris Raborg <[email protected]>
Co-authored-by: Eoin McAfee <[email protected]>
Co-authored-by: Julien Duchesne <[email protected]>
Co-authored-by: Harrison Katz <[email protected]>
Co-authored-by: Marko Gaćeša <[email protected]>
Co-authored-by: Marie <[email protected]>
Co-authored-by: Kamesh Sampath <[email protected]>
Co-authored-by: Dan Wilson <[email protected]>
Co-authored-by: Brad Rydzewski <[email protected]>
Co-authored-by: Sean Ryan <[email protected]>
Co-authored-by: Dimitris Sotirakis <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Soumyajit Das <[email protected]>
Co-authored-by: dependabot-ci <[email protected]>
@tonglil
Copy link
Contributor

tonglil commented Sep 12, 2023

I'm also wondering why the CLI prints

2022/11/04 17:43:46 proto: duplicate proto type registered: PluginSpec
2022/11/04 17:43:46 proto: duplicate proto type registered: PluginPrivilege

on every invocation?

@tphoney
Copy link
Contributor

tphoney commented Sep 12, 2023

it has to to with there being 2 ways to execute a drone yaml in the cli tool. there is the exec and exec_old. the error message is harmless, we plan to remove the deprecated exec_old soon. and this message will dissappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tphoney tphoney tphoney approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsotirakis @tphoney @tonglil