replace metadata.name "fullname" with "name" in helm-guestbook deployment and service yamls #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example tutorial on: https://developer.harness.io/docs/continuous-delivery/get-started/cd-tutorials/helm-chart?deploymentui=bgui
Deployments were failing due to the deployment & service names being longer than 64 chars. Although the helpers file truncates them to 64 chars, when doing blue/green, Harness adds "-stage/green/blue" to the release name which makes it longer than 64 therefore failing.
By changing metadata.name from "helm-guestbook.fullname" to "helm-guestbook.name" this is avoided