Skip to content

V3.1.5 harmonic#31

Closed
devinschmitz wants to merge 23 commits intov3.1.5-jitofrom
v3.1.5-harmonic
Closed

V3.1.5 harmonic#31
devinschmitz wants to merge 23 commits intov3.1.5-jitofrom
v3.1.5-harmonic

Conversation

@devinschmitz
Copy link
Copy Markdown
Contributor

Overview

This PR doesn't actually need to merge, I am just opening it up to make it easier to review and comment on the v3.1.5-harmonic implementation.

@devinschmitz
Copy link
Copy Markdown
Contributor Author

There are a few mods that I don't see at all in this branch:

  1. Improved vote processing
  2. Harmonic validator ID

Comment thread core/src/banking_stage/consume_worker.rs
Comment thread core/src/banking_stage/decision_maker.rs Outdated
Comment thread core/src/banking_stage/decision_maker.rs Outdated
Comment thread core/src/banking_stage/scheduler_messages.rs
Comment thread core/src/banking_stage/vote_worker.rs
Comment thread core/src/block_stage/block_consumer.rs Outdated
Comment thread core/src/scheduler_synchronization.rs
Comment thread core/src/scheduler_synchronization.rs Outdated
Comment thread core/src/scheduler_synchronization.rs
Comment thread core/src/scheduler_synchronization.rs
Co-authored-by: devinschmitz <94090407+devinschmitz@users.noreply.github.com>
@cavemanloverboy
Copy link
Copy Markdown
Collaborator

cavemanloverboy commented Jan 7, 2026

There are a few mods that I don't see at all in this branch:

  1. Improved vote processing
  2. Harmonic validator ID

yea the vote processing was going to be in a followup, just wanted to get the core functionality first. the vote worker stuff all changed in 3.1 as well

as for validator id, i wanted to wait to add the id until we get this stable otherwise our mainnet stats will be brought down during testing

@devinschmitz
Copy link
Copy Markdown
Contributor Author

There are a few mods that I don't see at all in this branch:

  1. Improved vote processing
  2. Harmonic validator ID

yea the vote processing was going to be in a followup, just wanted to get the core functionality first. the vote worker stuff all changed in 3.1 as well

as for validator id, i wanted to wait to add the id until we get this stable otherwise our mainnet stats will be brought down during testing

Sounds good. We should create tasks in Linear for these items so we don't forget to do them.

@devinschmitz
Copy link
Copy Markdown
Contributor Author

Closing this - ready for review by Ottersec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants