Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery selectors and methods #5

Merged
merged 3 commits into from
Jun 12, 2017
Merged

Conversation

valexiev
Copy link

@valexiev valexiev commented May 4, 2016

Make it with standard JavaScript and Angular so there is no need for jQuery.

@harm-less
Copy link
Owner

Thanks for your pull request. It was on my to-do list to see if I could only make it only depend on jqLite.
I'll merge this pull tomorrow as well.

@harm-less
Copy link
Owner

Btw, in the karma config file a reference to jQuery is still there. Can you create another commit with this reference removed to see if the plugin would still pass in Travis CI?

@harm-less
Copy link
Owner

harm-less commented May 5, 2016

Hey, I ran the pull through Karma with jQuery removed from karma.conf.js, but this breaks it as I was afraid of.
I think this needs to be fixed if this pull-request will make any sense, what about you?

In branch pr/5 you'll be able to see this.

@harm-less
Copy link
Owner

I'm not entirely sure what you meant with your line comment. But I don't think Karma is necessarily dependent on jQuery. It's just that the current state of the code (even with your changes), without jQuery it doesn't pass.
But if those errors can be fixed, the resulting build will be an Angular Sticky that will work without jQuery.

@codeuniquely
Copy link

Can this branch be integrated please - ???

@harm-less harm-less merged commit 3b81a28 into harm-less:master Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants