fix(breadcrumbs): support computed overrides #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the type of `overrides` in `BreadcrumbProps` from an array to `MaybeRefOrGetter<(BreadcrumbItemProps | false | undefined)[]>` to allow for computed values. - Updated the assignment of `overrides` to use `toValue` for proper reactive handling of the `options.overrides`.
|
@thorge is attempting to deploy a commit to the My Team Team on Vercel. A member of the Team first needs to authorize it. |
harlan-zw
approved these changes
Oct 16, 2024
harlan-zw
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces enhancements to the
useBreadcrumbItemsfunction in order to facilitate the dynamic updating of breadcrumbs, e. g. based on route parameters.🔗 Linked issue
Resolves #327
❓ Type of change
📚 Description
overridesinBreadcrumbPropsfrom an array toMaybeRefOrGetter<(BreadcrumbItemProps | false | undefined)[]>to allow for computed values.overridesto usetoValuefor proper reactive handling of theoptions.overrides.