-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use System HarfBuzz #201
Use System HarfBuzz #201
Conversation
@khaledhosny please let me know if this is acceptable. CC @gorloffslava. |
Fixed crashes when building on Python <3.9
thanks for this PR! |
@anthrotype awesome - thanks so much for the help on this. really appreciate it. |
it looks like it failed with the same error so your PR is not the culprit I'd say let's not block this PR on the PyPy issue. I was wondering, how easy or difficult would be to set up the CI to also test with USE_SYSTEM_LIBS=1? It'd be ok to only test this on linux |
Thank you!
I can put this in our backlog. We're juggling a lot with a small team (other contributions to tons of open source libs in addition to the platform we're building) so anything we can offload for now is greatly appreciated. |
thanks, I just tested this locally and I can confirm it works. I'll open an issue for exercising the USE_SYSTEM_LIBS=1 on our CI as well. |
Thanks @anthrotype |
https://github.com/harfbuzz/uharfbuzz/releases/tag/v0.39.4 EDIT: arghh.. the upload to pypi failed. I had to tag a new release, sorry! v0.39.5 is gonna work |
Resolves #45.
Adds the ability to use system HarfBuzz and associated documentation.