Fix: Return shadow host for text node in shadow root in SerializedAXNode.ElementHandle (#15451) - #3595
Merged
Conversation
…ode.ElementHandle (#15451) When a StaticText AX node sits directly in a shadow root, parentElement is null. Fall back to the shadow host so ElementHandleAsync returns a usable ElementHandle instead of a null-wrapped JSHandle. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
CHROME-headful-ubuntu-latest-cdp failed on tip 7836344 with Protocol error (Target.createTarget): Failed to open a new tab, then TargetClosedException on retries. PR only changes Firefox.DefaultBuildId; same flake was empty-committed on sibling rolls (#3592/#3595/#3572). Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
kblok
added a commit
that referenced
this pull request
Sep 24, 2026
* Fix: Roll Firefox DefaultBuildId to stable_156.0.1 (#15483) Port of puppeteer/puppeteer#15483. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * chore: retrigger CI after headful Chrome flakes Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue stuck build workflow Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue stuck matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung firefox headful Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung firefox matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung matrix Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung firefox headful Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung firefox headful Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung firefox headful Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: retrigger after ShouldKeepConnectedAfterTheLastPageIsClosed flake CHROME-headful-ubuntu-latest-cdp failed on tip 7836344 with Protocol error (Target.createTarget): Failed to open a new tab, then TargetClosedException on retries. PR only changes Firefox.DefaultBuildId; same flake was empty-committed on sibling rolls (#3592/#3595/#3572). Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: retrigger after CHROME-headless-ubuntu-cdp-pipe flake Tip 9f7b38e failed on CHROME-headless-ubuntu-latest-cdp-pipe after two full 882-pass runs aborted by host process exit, then PageGoBackTests.ShouldWork NullReferenceException. Known Chrome NRE cascade flake; PR only rolls Firefox.DefaultBuildId. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> * ci: requeue hung FIREFOX-headless (≥90m stagnant) Tip cb69e7e reached 16/17 SUCCESS; FIREFOX-headless-ubuntu-latest-webdriverbidi stagnant ≥90m (~90.3m job). Authorized hang requeue only — no code changes. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements changes from puppeteer/puppeteer#15451
Returns the shadow host for a text node in a shadow root when resolving SerializedAXNode.ElementHandle.