New Feature: Roll to Firefox 156.0 (#15464) - #3593
Merged
Merged
Conversation
Ports upstream puppeteer/puppeteer#15464: bump Firefox.DefaultBuildId to stable_156.0 and drop the linux Firefox Page.record FAIL expectation (mozilla bug 2066782 fixed). Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
kblok
marked this pull request as ready for review
September 23, 2026 13:44
WebDriverBiDi.NET serializes unset optionals as JSON null. Firefox 156 rejects browsingContext.startScreencast with "video": null. Omit null fields to match upstream Puppeteer (undefined omitted), so Page.record works after removing the linux Firefox FAIL expectation for #15464. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Firefox 156 fixed mozilla bug 2066782. Same removal as #15464/#3593; needed on the 156.0.1 roll branch because #15464 is not yet merged to master. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports upstream puppeteer/puppeteer#15464: bump Firefox to
stable_156.0and drop the linux FirefoxPage.recordFAIL expectation (mozilla bug 2066782).CI fix
Firefox BiDi
ShouldRecordPagefailed after removing the FAIL expectation becausebrowsingContext.startScreencastwas sent with"video": null. WebDriverBiDi.NET does not omit null optionals by default; Firefox 156 rejects nullvideo. Added[JsonIgnore(Condition = WhenWritingNull)]on screencastaudio/video(and nested video fields) so payloads match upstream JS (undefined omitted).Chrome Ubuntu failures on this run (
ShouldKeepConnectedAfterTheLastPageIsClosed, headless-shell host abort onShouldThrowWhenPageCrashes) look like flakes unrelated to the Firefox roll; no code change for those.Test plan
BROWSER=FIREFOX PROTOCOL=bidiShouldRecordPage/PageRecordTestspass locally