New Feature: Implement page.record() video-stream screen recording (upstream #15387) by kblok · Pull Request #3571 · hardkoded/puppeteer-sharp

kblok · 2026-09-03T15:14:38Z

Summary

Ports puppeteer/puppeteer#15387: page.record() video-stream screen recording (CDP + BiDi), writable destinations, and matching tests/expectations.

Notes

Rebased onto master after Fix: Roll to Firefox 154.0.1 (upstream #15397) #3573 (Firefox 154.0.1) and Fix: Do not miss the first screencast frame while startScreencast is in flight (upstream #15389) #3578 (screencast docs) merged — conflict was only whitespace in workflow concurrency.
Path-backed recordings dispose the underlying stream on End() to match upstream WritableDestination.end().
Firefox Page.record remains expected FAIL on all platforms per upstream expectations (narrowed to linux-only in follow-up New Feature: Roll to Firefox 155.0 (upstream #15408) #3577 / upstream #15408).

Part of the puppeteer-core-v25.10.0 port.

cursor · 2026-09-04T00:41:38Z

CI blocker — please cancel superseded run

This PR’s HEAD is 0eeb8c9, but an older run is still consuming runners:

https://github.com/hardkoded/puppeteer-sharp/actions/runs/33798937997 (sha 7487855) — stuck on FIREFOX-headful-ubuntu-latest-webdriverbidi (Test Linux since ~23:36Z) and also CHROME-headless-ubuntu-latest-cdp

gh run cancel returns 403 for this agent. Cancelling that run would free runners for the current HEAD checks on this and sibling 25.10.0 PRs.

…pstream #15387) Port upstream Puppeteer PR #15387 adding video-stream-based screen recording via Page.record() / RecordAsync(), replacing the ffmpeg-based screencast flow for new recordings. - Add RecordOptions, ScreenRecording, IWritableDestination APIs - Implement CdpScreenRecording (Page.startScreenRecording + IO.read stream) - Implement BidiScreenRecording (browsingContext.start/stopScreencast) - Deprecate ScreencastAsync in favor of RecordAsync - Port page.test record integration test and ScreenRecording validation test - Sync upstream test expectations for Page.record on Chrome/Firefox Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

…Recording Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

…ge.record() Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Upstream #15387 marks Page.record as FAIL on all platforms for Firefox. The linux-only narrowing belongs to upstream #15408. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Match upstream WritableDestination.end() so FileStreams opened for RecordOptions.Path release their handles after StopAsync. Also add workflow concurrency to cancel superseded runs on this PR. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Watch #3571 FF-headful, #3576 new FF jobs after hang cancel, and #3580 attempt-N+1 FF/chrome after successful run-cancel+rerun. Skip #3575/#3577 (fully green). Keep run-cancel (not job-cancel). Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Match current upstream TestExpectations after #15408: Firefox Page.record remains expected FAIL on linux only (Bug 2066782). The Chrome FAIL entry is unchanged. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Unstack from #3571 so this PR only contains the Firefox version bump. Page.record TestExpectations (including the linux-only Firefox FAIL narrow from upstream #15408) belong on #3571 to match current upstream. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Prior helper re-ran the old #3571 build which concurrency-cancelled the fc0d8e3 HEAD build. Cancel old run without rerun, full-rerun new HEAD, and keep hang-watch only on #3576/#3580 (run-cancel, not job-cancel). Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Ubuntu helper queued 6m+ behind open-PR matrix; old #3571 FF still stealing runners. windows-latest + bash + python for faster pickup. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Watch #3571 FF-headless/headful for Test≥120m run-cancel + idle-rerun of chrome-headful flake. Also watch #3576 attempt3 FF-headless for hang. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Watch job 101057206221 / run 33869194949; cancel+rerun at Test>=120m. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Hang helper cancelled FF-hl at ~120m and rerun-failed; attempt4 FF-hl requeued. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Watch job 101098115593 / run 33869194949; cancel+rerun at Test>=120m. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Hang helper cancelled FF-hl at ~120m and rerun-failed; attempt5 FF-hl requeued. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Poll until Test ≥120m then cancel run + rerun-failed; exits clean if job finishes. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

All open release PRs (#3571/#3576/#3577) have gh pr checks exit 0. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Unstack from #3571 so this PR only contains the Firefox version bump. Page.record TestExpectations (including the linux-only Firefox FAIL narrow from upstream #15408) belong on #3571 to match current upstream. Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.8.0 to 25.10.0. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.10.0 ## What's Changed * fix: set frame content without document.write (#15358) by @kblok in hardkoded/puppeteer-sharp#3565 * feat: roll to Firefox 154.0 (#15361) by @kblok in hardkoded/puppeteer-sharp#3566 * New Feature: Support shadow roots in MutationPoller (#15292) by @kblok in hardkoded/puppeteer-sharp#3564 * fix: roll to Chrome 152.0.7977.54 (#15363) by @kblok in hardkoded/puppeteer-sharp#3567 * chore: bump version to 25.9.0 by @kblok in hardkoded/puppeteer-sharp#3568 * New Feature: Support canceling WebMCP tool execution (#15365) by @kblok in hardkoded/puppeteer-sharp#3563 * Update README.md - update downloads badge by @Meir017 in hardkoded/puppeteer-sharp#3569 * Fix: Roll to Chrome 152.0.7977.64 (upstream #15395) by @kblok in hardkoded/puppeteer-sharp#3574 * Fix: Do not miss the first screencast frame while startScreencast is in flight (upstream #15389) by @kblok in hardkoded/puppeteer-sharp#3578 * Fix: Roll to Firefox 154.0.1 (upstream #15397) by @kblok in hardkoded/puppeteer-sharp#3573 * Fix: Detect a websocket connection that died without a close (upstream #15406) by @kblok in hardkoded/puppeteer-sharp#3570 * Fix: Distinguish an unwritable userDataDir from a running browser (upstream #15405) by @kblok in hardkoded/puppeteer-sharp#3572 * Fix: Roll to Chrome 152.0.7977.75 (upstream #15409) by @kblok in hardkoded/puppeteer-sharp#3575 * chore: add newer iPhone KnownDevices (upstream #15400) by @kblok in hardkoded/puppeteer-sharp#3580 * chore: bump version to 25.10.0 by @kblok in hardkoded/puppeteer-sharp#3576 * New Feature: Implement page.record() video-stream screen recording (upstream #15387) by @kblok in hardkoded/puppeteer-sharp#3571 * New Feature: Roll to Firefox 155.0 (upstream #15408) by @kblok in hardkoded/puppeteer-sharp#3577 **Full Changelog**: hardkoded/puppeteer-sharp@v25.8.0...v25.10.0 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.8.0...v25.10.0). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PuppeteerSharp&package-manager=nuget&previous-version=25.8.0&new-version=25.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

cursor Bot mentioned this pull request Sep 3, 2026

New Feature: Roll to Firefox 155.0 (upstream #15408) #3577

Merged

kblok marked this pull request as ready for review September 4, 2026 01:36

This was referenced Sep 4, 2026

chore: bump version to 25.10.0 #3576

Merged

Fix: Roll to Firefox 154.0.1 (upstream #15397) #3573

Merged

cursoragent and others added 6 commits September 4, 2026 03:33

Fix netstandard2.0 Stream.Write compatibility in ScreenRecording

234103b

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

Fix netstandard2.0 File.ReadAllBytesAsync compatibility in BidiScreen…

387a25a

…Recording Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

ci: rerun after flaky Chrome headful/windows failures unrelated to pa…

3094188

…ge.record() Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

test: match upstream #15387 Page.record Firefox expectations platforms

ae94edf

Upstream #15387 marks Page.record as FAIL on all platforms for Firefox. The linux-only narrowing belongs to upstream #15408. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot force-pushed the cursor/implement-upstream-15387-c423 branch from 26179cf to e43fa38 Compare September 4, 2026 03:33

cursor Bot deleted the cursor/implement-upstream-15387-c423 branch September 4, 2026 03:36

cursor Bot restored the cursor/implement-upstream-15387-c423 branch September 4, 2026 03:36

cursor Bot mentioned this pull request Sep 4, 2026

Fix: Roll to Chrome 152.0.7977.75 (upstream #15409) #3575

Merged

test: sync Page.record Firefox FAIL expectation to linux only

fc0d8e3

Match current upstream TestExpectations after #15408: Firefox Page.record remains expected FAIL on linux only (Bug 2066782). The Chrome FAIL entry is unchanged. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: re-arm hang helper for #3571 FF-hl attempt3 (~84m)

454d8a2

Watch job 101057206221 / run 33869194949; cancel+rerun at Test>=120m. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: restore noop after helper SUCCESS (#3571 hang→attempt4)

19757ab

Hang helper cancelled FF-hl at ~120m and rerun-failed; attempt4 FF-hl requeued. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: re-arm hang helper for #3571 FF-hl attempt4 (~87m)

823f47d

Watch job 101098115593 / run 33869194949; cancel+rerun at Test>=120m. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: restore noop after helper SUCCESS (#3571 hang→attempt5)

7d20768

Hang helper cancelled FF-hl at ~120m and rerun-failed; attempt5 FF-hl requeued. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: re-arm hang helper for #3571 FF-hl attempt5 (~35m)

f4c61ce

Poll until Test ≥120m then cancel run + rerun-failed; exits clean if job finishes. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

cursor Bot pushed a commit that referenced this pull request Sep 4, 2026

ci: restore noop after helper SUCCESS (#3571 attempt5 green)

20a8baf

All open release PRs (#3571/#3576/#3577) have gh pr checks exit 0. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>

kblok merged commit cf54a29 into master Sep 5, 2026
46 of 61 checks passed

kblok deleted the cursor/implement-upstream-15387-c423 branch September 5, 2026 18:07

dependabot Bot mentioned this pull request Sep 13, 2026

deps(nuget): bump PuppeteerSharp from 25.8.0 to 25.10.0 sondresjolyst/garge-api#412

Merged

This was referenced Sep 16, 2026

Bump PuppeteerSharp from 25.1.2 to 25.11.0 afnan/allspice-clean-modular-monolith-template#69

Open

Bump PuppeteerSharp from 25.8.0 to 25.11.0 DavidSdot/CardCrawler#42

Open

Bump PuppeteerSharp from 21.0.1 to 25.11.0 aaronlovi/tsx-aggregator#37

Open

Navigation Menu

Uh oh!

New Feature: Implement page.record() video-stream screen recording (upstream #15387) - #3571

New Feature: Implement page.record() video-stream screen recording (upstream #15387)#3571
kblok merged 7 commits into
masterfrom
cursor/implement-upstream-15387-c423

kblok commented Sep 3, 2026 •

edited by cursor Bot

Loading

Uh oh!

cursor Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kblok commented Sep 3, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Uh oh!

cursor Bot commented Sep 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kblok commented Sep 3, 2026 •

edited by cursor Bot

Loading