Fix: don't throw in checkVisibility for a detached text node - #3525
Merged
Conversation
Ports puppeteer/puppeteer#15197. isHidden()/isVisible() resolve a text node to its parent element before calling getComputedStyle, but a text node that was never attached to the DOM has parentElement === null, so getComputedStyle(null) throws instead of resolving to "hidden". Adds the same guard used upstream (mirroring the existing `if (!node) return visible === false;` check one level down, after the parent lookup) and a regression test using an orphan text node created via document.createTextNode.
This was referenced Jul 29, 2026
This was referenced Aug 7, 2026
sondresjolyst
pushed a commit
to sondresjolyst/garge-api
that referenced
this pull request
Aug 10, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.3.4 to 25.4.0. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.4.0 ## What's Changed * Roll Chrome to 151.0.7922.47 (#15237) by @kblok in hardkoded/puppeteer-sharp#3524 * New Feature: Add browser-level PWA install/launch/uninstall APIs (#15235) by @kblok in hardkoded/puppeteer-sharp#3523 * New Feature: Expose Handled getter on Dialog (#15225) by @kblok in hardkoded/puppeteer-sharp#3521 * Fix: don't throw in checkVisibility for a detached text node by @kblok in hardkoded/puppeteer-sharp#3525 * Fix: Roll to Firefox 152.0.5 (#15219) by @kblok in hardkoded/puppeteer-sharp#3527 * Fix: combine duplicate BiDi response headers instead of overwriting (#15203) by @kblok in hardkoded/puppeteer-sharp#3526 * Bump version to 25.4.0 by @kblok in hardkoded/puppeteer-sharp#3528 **Full Changelog**: hardkoded/puppeteer-sharp@v25.3.4...v25.4.0 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.3.4...v25.4.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 14, 2026
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
isHidden()/isVisible()on anElementHandlewrapping a text node that was never attached to the DOM (e.g.document.createTextNode('x')with no parent) threw aTypeErrorinstead of returningtruefor hidden.checkVisibilityresolves a text node to itsparentElementbefore callinggetComputedStyle, and a detached text node hasparentElement === null, sogetComputedStyle(null)blew up.Ports the fix from puppeteer/puppeteer#15197: same guard as the existing
if (!node) return visible === false;check, just one level down after the parent lookup. Added a regression test inIsVisibleIsHiddenTestsusing an orphan text node created viadocument.createTextNode.