Fix Locator.SetVisibility(Hidden).WaitAsync() resolving immediately - #3514
Merged
Merged
Conversation
…instead of waiting NodeLocator was setting Visible=false for the Hidden case instead of the separate Hidden=true flag, so the underlying wait never actually checked visibility and resolved as soon as the element existed in the DOM. Fixed by routing through the correct Hidden flag, and handled the resulting null-handle case (element removed from DOM) as a valid resolution instead of an error, guarding the downstream WaitAsync/PerformActionAsync call sites against it. Fixes #3513 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
This was referenced Jul 19, 2026
sondresjolyst
pushed a commit
to sondresjolyst/garge-api
that referenced
this pull request
Jul 20, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.3.1 to 25.3.3. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.3.3 ## What's Changed * Fix Native AOT crash from missing JsonSerializable registrations by @kblok in hardkoded/puppeteer-sharp#3516 **Full Changelog**: hardkoded/puppeteer-sharp@v25.3.2...v25.3.3 ## 25.3.2 ## What's Changed * Fix Locator.SetVisibility(Hidden).WaitAsync() resolving immediately by @kblok in hardkoded/puppeteer-sharp#3514 **Full Changelog**: hardkoded/puppeteer-sharp@v25.3.1...v25.3.2 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.3.1...v25.3.3). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Jul 20, 2026
This was referenced Jul 29, 2026
This was referenced Aug 7, 2026
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3513.
NodeLocatorwas settingVisible = falseforVisibilityOption.Hiddeninstead of the separateHidden = trueflag onWaitForSelectorOptions. Since the underlyingQueryHandler.WaitForAsynconly checks visibility whenVisible || Hiddenis true, that flag never got set for the Hidden case, so the wait resolved as soon as the element existed in the DOM — regardless of whether it was actually visible.Fixed by routing
Hiddenthrough the correct flag. That also exposed a second bug: waiting for Hidden can legitimately resolve to anullhandle when the element is removed from the DOM entirely (documented behavior ofWaitForSelectorAsync), butNodeLocatorand a few call sites inLocatortreated that as an error/NRE instead of success. Handled that too, since it's the same feature area and would've broken the moment someone waited for an element to disappear rather than just godisplay: none.Added regression tests covering both the CSS-hide and DOM-removal flavors of "hidden."
Test plan
BROWSER=CHROME PROTOCOL=cdp dotnet test --filter "FullyQualifiedName~LocatorTests"— 39/39 passed