fix: open a new window when creating a page with no existing targets#3481
Merged
Conversation
When all pages are closed in headful Chrome on Linux, the browser window closes. Subsequent `Target.createTarget` calls fail with "Failed to open a new tab" because there is no window to add a tab to. Setting `newWindow: true` tells Chrome to create a new browser window, fixing the `ShouldKeepConnectedAfterTheLastPageIsClosed` test failure on CHROME-headful-ubuntu. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ndow exists When all pages are closed in headful mode, Chrome has no browser window. The first createTarget attempt now returns "Failed to open a new tab" from Chrome (Chrome is alive but has no window), and we retry with newWindow=true to open a fresh window — instead of proactively sending newWindow=true which could race with Chrome's TCP teardown and produce a WebSocketException. Also handle the WebSocketException race in Connection.SendAsync: if Chrome exits between the IsClosed check and the actual send, convert the raw socket error into a clean TargetClosedException. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kblok
changed the title
The previous commit added a retry on "Failed to open a new tab" which couples us to Chrome's internal error message. Revert to the simpler approach: always pass newWindow=true when there are no existing targets. The WebSocketException race fix in Connection.SendAsync already covers the case where Chrome exits between the IsClosed check and the send. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kblok
changed the title
This was referenced Jun 17, 2026
This was referenced Jun 26, 2026
sondresjolyst
pushed a commit
to sondresjolyst/garge-api
that referenced
this pull request
Jun 29, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.1.0 to 25.1.2. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.1.2 ## What's Changed * fix: open a new window when creating a page with no existing targets by @kblok in hardkoded/puppeteer-sharp#3481 * fix: support WebDriverBiDi 0.0.54+ (fixes #3479) by @kblok in hardkoded/puppeteer-sharp#3480 **Full Changelog**: hardkoded/puppeteer-sharp@v25.1.1...v25.1.2 ## 25.1.1 ## What's Changed * Avoid leaking TargetChangedArgs event handlers by @jnyrup in hardkoded/puppeteer-sharp#3476 * fix: ensure CDP-only package is compiled without WebDriverBiDi references by @kblok in hardkoded/puppeteer-sharp#3478 **Full Changelog**: hardkoded/puppeteer-sharp@v25.1.0...v25.1.1 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.1.0...v25.1.2). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In headful Chrome on Linux, closing all tabs also closes the browser window. When
NewPageAsync()is called after that,Target.createTargetfails with "Failed to open a new tab" — Chrome has no window to put the tab into.Pass
newWindow: truewhen there are no existing targets, so Chrome opens a fresh window. Also handle the WebSocket abort race inConnection.SendAsync: if Chrome exits between theIsClosedcheck and the send, convert the raw socket error into a cleanTargetClosedException.Fixes
ShouldKeepConnectedAfterTheLastPageIsClosedonCHROME-headful-ubuntu-latest-cdp.