Skip to content

fix: ensure CDP-only package is compiled without WebDriverBiDi references #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kblok merged 2 commits into from
Jun 12, 2026
Merged

fix: ensure CDP-only package is compiled without WebDriverBiDi references #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f5d39c
fix: ensure CDP-only package is compiled without WebDriverBiDi refere…
kblok Jun 11, 2026
41f013f
chore: bump version to 25.1.1
kblok Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/PushNugetPackageToIntNugetOrg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ jobs:
- name: Restore (CDP only)
run: |
dotnet restore lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY
- name: Build and Pack (CDP only)
- name: Build (CDP only)
run: |
dotnet pack lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY /p:Title=PuppeteerSharp.Cdp /p:PackageId=PuppeteerSharp.Cdp /p:Description="Headless Browser .NET API with CDP support only (no WebDriverBiDi)" --configuration Release --no-restore
dotnet build lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY --configuration Release --no-restore --no-incremental
- name: Pack (CDP only)
run: |
dotnet pack lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY /p:Title=PuppeteerSharp.Cdp /p:PackageId=PuppeteerSharp.Cdp /p:Description="Headless Browser .NET API with CDP support only (no WebDriverBiDi)" --configuration Release --no-restore --no-build
ls ./lib/PuppeteerSharp/bin/Release
- name: NugetPush to int.nuget.org (CDP only)
env:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/PushNugetPackageToNugetOrg.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ jobs:
- name: Restore (CDP only)
run: |
dotnet restore lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY
- name: Build and Pack (CDP only)
- name: Build (CDP only)
run: |
dotnet pack lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY /p:Title=PuppeteerSharp.Cdp /p:PackageId=PuppeteerSharp.Cdp /p:Description="Headless Browser .NET API with CDP support only (no WebDriverBiDi)" --configuration Release --no-restore
dotnet build lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY --configuration Release --no-restore --no-incremental
- name: Pack (CDP only)
run: |
dotnet pack lib/PuppeteerSharp/PuppeteerSharp.csproj /p:DefineConstants=CDP_ONLY /p:Title=PuppeteerSharp.Cdp /p:PackageId=PuppeteerSharp.Cdp /p:Description="Headless Browser .NET API with CDP support only (no WebDriverBiDi)" --configuration Release --no-restore --no-build
ls ./lib/PuppeteerSharp/bin/Release
- name: NugetPush to nuget.org (CDP only)
env:
Expand Down
3 changes: 2 additions & 1 deletion lib/Common/CommonProps.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
<Link>keypair.snk</Link>
</None>
</ItemGroup>
<Target Name="PreBuild" BeforeTargets="PreBuildEvent">
<Target Name="PreBuild" BeforeTargets="PreBuildEvent"
Condition=" !$(DefineConstants.Contains('CDP_ONLY')) ">
<Exec Command="dotnet format $(ProjectPath) --exclude-diagnostics CA1865" />
</Target>
</Project>
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/PuppeteerSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<Description>Headless Browser .NET API</Description>
<PackageId>PuppeteerSharp</PackageId>
<PackageReleaseNotes></PackageReleaseNotes>
<PackageVersion>25.1.0</PackageVersion>
<ReleaseVersion>25.1.0</ReleaseVersion>
<AssemblyVersion>25.1.0</AssemblyVersion>
<FileVersion>25.1.0</FileVersion>
<PackageVersion>25.1.1</PackageVersion>
<ReleaseVersion>25.1.1</ReleaseVersion>
<AssemblyVersion>25.1.1</AssemblyVersion>
<FileVersion>25.1.1</FileVersion>
<SynchReleaseVersion>false</SynchReleaseVersion>
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<DebugType>embedded</DebugType>
Expand Down
Loading