Implement frame.frameElement() for WebDriver BiDi#3152
Merged
Conversation
kblok
force-pushed
the
implement-upstream-change-3115
branch
from
d32d11c to
55c1a8a
Compare
Override FrameElementAsync in BidiFrame to use native BiDi browsingContext.locateNodes with ContextLocator, enabling proper support for frames in shadow DOM. Also adds FrameElement tests ported from upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kblok
force-pushed
the
implement-upstream-change-3115
branch
from
55c1a8a to
409083a
Compare
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameElementAsyncinBidiFrameto use native BiDibrowsingContext.locateNodeswithContextLocator, enabling proper support for frames inside shadow DOMstartNodesparameter optional inBrowsingContext.LocateNodesAsyncFrameElementAsyncvirtual in the baseFrameclass to allow protocol-specific overridesFrameElementtests ported from upstream (should work,should handle shadow roots,should return ElementHandle in the correct world)FrameElementissuesUpstream PR
Implements puppeteer/puppeteer#14629
Closes #3115
Test plan
🤖 Generated with Claude Code