feat(bidi): Improve window management error handling#3150
Merged
Conversation
…expectations Port upstream puppeteer PR #14618. Add try/catch with logging around SetWindowBoundsAsync in BidiBrowserContext.NewPageAsync and improve the existing setViewport catch to log errors instead of silently swallowing them. Use a _logger field initialized in the constructor. Update test expectations from webDriverBiDi to firefox for window management tests now that BiDi supports them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kblok
force-pushed
the
implement-upstream-change-3116
branch
from
ea33deb to
b403d4f
Compare
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetWindowBoundsAsyncinBidiBrowserContext.NewPageAsync()to tolerate browsers that don't supportbrowser.setClientWindowStatesetViewportcatch to log errors viaILoggerinstead of silently swallowing themwebDriverBiDitofirefoxfor window management tests, since BiDi now supports them on ChromeTest plan
NewPageTestspass with Chrome/CDP (3 passed, 1 skipped)Closes #3116
🤖 Generated with Claude Code