Sync tracing tests with upstream Puppeteer#3137
Merged
Conversation
- Fix ShouldThrowIfTracingOnTwoPages to start tracing on newPage (not same page) - Rename "should return a buffer" to "should return a typedArray" to match upstream - Rename "should support a buffer without a path" to "should support a typedArray without a path" - Add missing test "should properly fail if readProtocolStream errors out" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix StopAsync hang: propagate exception via TrySetException on TaskCompletionSource when ProtocolStreamReader fails - Fix ShouldThrowIfTracingOnTwoPages to start tracing on newPage - Rename test attributes to match upstream (buffer -> typedArray) - Add missing test for readProtocolStream error handling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShouldThrowIfTracingOnTwoPages: Was incorrectly callingPage.Tracing.StartAsync(same page) instead ofnewPage.Tracing.StartAsync— now matches upstream behavior of testing tracing on a different page"should return a buffer"→"should return a typedArray"and"should support a buffer without a path"→"should support a typedArray without a path"to match upstream renames"should properly fail if readProtocolStream errors out"— tests error handling when writing trace to an invalid path (directory instead of file)Test plan
TracingTestssuite with Chrome/CDP🤖 Generated with Claude Code