Merged
Conversation
Add ResizeAsync method to IPage/Page that resizes the browser window content area to specified dimensions using Browser.getWindowForTarget and Browser.setContentsSize CDP commands. Test is skipped until Chrome is updated to a version that supports Browser.setContentsSize. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move resize BiDi skip expectation from local to upstream.json to match upstream TestExpectations. Add local skip for ShouldTriggerCorrectLog which changed CORS error message in Chrome 145. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Split SharedWorker/ServiceWorker close logic in CdpWebWorker to match upstream (SharedWorker only closes target, no detach) and add null guards on Connection - Update tracing test to verify traceEvents categories instead of removed trace-config metadata - Fix request interception tests to use server page instead of data: URL and filter favicon requests, matching upstream - Increase OOPIF frame wait timeout for cross-process frame creation on slower CI machines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResizeAsync(int contentWidth, int contentHeight)toIPageandPage(abstract)CdpPageusingBrowser.getWindowForTargetandBrowser.setContentsSizeNotSupportedExceptionstub inBidiPage(matching upstream which throws "Method not implemented for WebDriver BiDi yet")page.specforPage.resizeTestExpectations.local.jsonbecauseBrowser.setContentsSizeis not yet available in Chrome 138 (upstream uses Chrome 145+)Changes
IPage.csResizeAsyncmethod to interfacePage.csResizeAsyncmethodCdpPage.csBrowser.getWindowForTarget+Browser.setContentsSizeBidiPage.csNotSupportedExceptionBrowserGetWindowForTargetResponse.csBrowserSetContentsSizeRequest.csSystemTextJsonSerializationContext.csResizeTests.csTestExpectations.local.jsonUpstream PR
puppeteer/puppeteer#14525
Test plan
Browser.setContentsSize, remove the skip entry and verify the test passes🤖 Generated with Claude Code