Migrate from postData to postDataEntries in CdpHttpRequest#3126
Merged
Migrate from postData to postDataEntries in CdpHttpRequest#3126
Conversation
Use postDataEntries (base64-encoded) from CDP protocol instead of the deprecated postData field. Falls back to postData when entries are missing. Ports upstream puppeteer PR #14640. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Migrate implement-upstream-change and implement-bidi-feature from .claude/commands/ to .claude/skills/ format - Add PuppeteerTest attributes to CdpHttpRequestTests to match upstream - Remove obsolete .github/agents/ definitions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postDataEntries(base64-encoded) from the CDP protocol instead of the deprecatedpostDatafield inNetwork.requestWillBeSentpostDatawhenpostDataEntriesis missing or empty, maintaining backward compatibilityChanges
PostDataEntry.cs— New messaging class for CDPPostDataEntrytypeRequest.cs(Messaging) — AddedPostDataEntriespropertyCdpHttpRequest.cs— AddedReconstructPostDatamethod that decodes base64 entries and merges them, replacing directpostDataassignmentCdpHttpRequestTests.cs— Unit tests for reconstruction and fallback behaviorTest plan
RequestPostDatatests passRequestContinueinterception tests passNetworkManagertests pass🤖 Generated with Claude Code