Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Introduce Wait for device prompt #2392

Merged
merged 10 commits into from
Jan 6, 2024
Merged

Conversation

kblok
Copy link
Member

@kblok kblok commented Jan 5, 2024

Breaking changes

  • IBrowser.WaitForTargetAsync options type we rename from WatForOptions to WaitTimeoutOptions.
  • IPage.WaitForFileChooserAsync options type we rename from WaitForFileChooserOptions to WaitTimeoutOptions.
  • IPage.WaitForRequestAsync options type we rename from WatForOptions to WaitTimeoutOptions.
  • IPage.WaitForResponseAsync options type we rename from WatForOptions to WaitTimeoutOptions.

closes #2178

@kblok kblok added this pull request to the merge queue Jan 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2024
* Implemented tests

* Feature complete

* code style

* cr

* cr

* check null context

* fix test
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@kblok kblok added this pull request to the merge queue Jan 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2024
@kblok kblok added this pull request to the merge queue Jan 6, 2024
Merged via the queue into master with commit e8a8133 Jan 6, 2024
8 checks passed
@kblok kblok deleted the wait-for-device-prompt branch January 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tests DeviceRequestPrompt.spec.ts
1 participant