Skip to content

Fix ShouldWorkForElementHandleWaitForSelector #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kblok merged 1 commit into from
Apr 9, 2023
Merged

Fix ShouldWorkForElementHandleWaitForSelector #2133

kblok merged 1 commit into from
Apr 9, 2023

Conversation

@jnyrup
Copy link
Contributor

@jnyrup jnyrup commented Apr 8, 2023

I noticed that element was unused, so looked up the corresponding puppeteer test
where WaitForSelectorAsync is called on element and not page.

@kblok kblok merged commit 41fe285 into hardkoded:master Apr 9, 2023
@jnyrup jnyrup deleted the ShouldWorkForElementHandleWaitForSelector branch April 9, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kblok kblok kblok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnyrup @kblok