docs: sync ROADMAP/CURRENT_STATE with Native Runtime v2.0 Phase B addendum + D - #82
Conversation
…endum + D Both files still described Phase B's cost-estimate half as deliberately deferred and Phase D as untouched -- stale since PR #76 (cost estimate), #77 (load-time measurement), #78 (negative fail-closed test), and #79 (cancellation-corruption fix) all landed since the last sync. Updates the Native Runtime v2.0 direction table in ROADMAP.md and the native_runtime note in CURRENT_STATE.yaml to reflect current reality: Phase B fully landed (estimate + measurement), Phase D essentially complete pending the E2E evidence-lane PR (#81, open). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation now records the latest Native Runtime v2.0 foundation-hardening progress, including VRAM accounting, load-time measurement, fail-closed behavior, cancellation recovery, E2E evidence, and continued non-default runtime gating. ChangesNative Runtime documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 23 minutes. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
… criteria (#83) Maps each of NATIVE_RUNTIME_V2_SPEC.md §6's entry criteria to a concrete, evidence-bearing campaign phase (HV-0..HV-6) across the real three-machine fleet: NewcorePC (Warchief, RTX 5070 Ti 16GB), HardcorePC (RTX 3050 6GB), HardcoreLaptopMSI (RTX 4060 8GB). Fleet surveyed live over SSH during planning (GPUs, drivers, repo paths/states verified, both remotes synced to master @ aa07f41); pinned test-GGUF distribution to both workers initiated with SHA-256 recorded for per-box verification. Honest blockers listed up front: HardcorePC's unresolved native-lib regression is a hard HV-0 precondition (and doubles as the campaign's first real diagnosability exercise), the laptop's CUDA-redist bundling must be verified per-box, and PR #81/#82 must merge first. The plan produces the §6 EVIDENCE only -- the flip itself stays gated on an explicit recorded product decision, per the spec. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/CURRENT_STATE.yaml`:
- Around line 107-109: Synchronize the real-model E2E evidence lane’s status by
adding the same pending-merge qualifier used in docs/ROADMAP.md lines 662-663 to
docs/CURRENT_STATE.yaml lines 107-109 and docs/ROADMAP.md line 676; update both
locations consistently, unless PR `#81` has landed, in which case record the
completed status instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3332c831-f8c6-4594-9235-0de916ea93f8
📒 Files selected for processing (2)
docs/CURRENT_STATE.yamldocs/ROADMAP.md
| real-model E2E lane with a retained JSON evidence artifact (discovery | ||
| through real admission through inference through telemetry; | ||
| 25.7 tok/s, 284ms TTFT, 2.5GB measured VRAM on the reference box) are |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Synchronize the E2E evidence lane’s merge status across both documents.
The foundation note and Phase 3 roadmap row omit that the real-model evidence lane is still pending merge, while docs/ROADMAP.md Lines [662-663] and the PR summary preserve that status.
docs/CURRENT_STATE.yaml#L107-L109: add the pending-merge qualifier, or update after PR#81lands.docs/ROADMAP.md#L676-L676: use the same pending-merge wording as Lines [662-663].
📍 Affects 2 files
docs/CURRENT_STATE.yaml#L107-L109(this comment)docs/ROADMAP.md#L676-L676
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/CURRENT_STATE.yaml` around lines 107 - 109, Synchronize the real-model
E2E evidence lane’s status by adding the same pending-merge qualifier used in
docs/ROADMAP.md lines 662-663 to docs/CURRENT_STATE.yaml lines 107-109 and
docs/ROADMAP.md line 676; update both locations consistently, unless PR `#81` has
landed, in which case record the completed status instead.
CodeRabbit finding: ROADMAP.md's banner still said the E2E lane was "built, verified on real hardware, and pending merge" while CURRENT_STATE.yaml's parallel note omitted that qualifier entirely -- inconsistent, and now stale either way since PR #81 actually merged. Updated both to say landed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 54 minutes. |
Summary
Docs-only sync. Both files still described Phase B's cost-estimate half as deliberately deferred and Phase D as untouched — stale since #76, #77, #78, and #79 all landed. Updates:
native_runtimestatus noteNo code changes.
🤖 Generated with Claude Code
Summary by CodeRabbit