CF-7 Phase E: retrospective grading + new NoKvSlot storm on Qwen3.5 (§7e, open) - #62
Conversation
Retrospectively applies the Remediation Phase 2/3 gates by hand to Meta-Llama's and qwen2.5-coder's already-completed runs (no re-run needed, since Phases C/D only changed scoring/gate logic): Meta-Llama's Graded capability gate would PASS (58 vs. best baseline 46) but ReadyForExpansion still fails on segment_terminal_coverage; qwen2.5-coder's would FAIL (29 vs. 52), the same NO-GO the old all-or-nothing gate reached, now for the documented right reason. Two fresh Qwen3.5-9B full 120-question runs (both quants, on fully-fixed master) hit a severe, previously-undocumented NoKvSlot storm that neither the SeqMax fix (§7b) nor the thinking-suppression fix (§7c) prevents, contradicting §7b's "zero NoKvSlot, verified live" claim on the same code. Documented as CONTEXT_FABRIC_BUG_HISTORY.md §7e (open, unresolved) with the failure signature and a diagnostic data point (Q4_K_M's smaller VRAM footprint reduces but does not eliminate the storm). Both runs' B3 scores are excluded from Phase E as corrupted-run artifacts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…s (grok review) grok found: the ~850 MiB headroom figure only works out if both role contexts are counted, but the prose only mentioned one; fixed to say both. Also found the "zero NoKvSlot" claim §7e says is downgraded was left unedited in its own section (§7b) and in the infrastructure compatibility table, so the operational status surface still stated the now-false absolute claim. Updated both to point at §7e. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe documentation records invalid Qwen3.5 CF-7 runs caused by recurring ChangesPhase E findings
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/CF_TEST_RESULTS.md`:
- Around line 223-227: Correct the ReadyForExpansion explanation so the 0.9
threshold is attributed only to citation_precision, not
boundary_stitch_pass_rate. In the paragraph around the ReadyForExpansion
conclusion, state that citation precision passes while boundary-stitch remains
unverified due to the earlier 0/2 results and lack of re-verification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5300215a-ce2d-496f-a2b9-0530ea5273bd
📒 Files selected for processing (3)
docs/CF_TEST_RESULTS.mddocs/CONTEXT_FABRIC_BUG_HISTORY.mddocs/CONTEXT_FABRIC_INFRASTRUCTURE_NOTES.md
…deRabbit) The 0.90 blocking threshold applies only to citation_precision, not boundary_stitch_pass_rate -- the retrospective wording implied boundary-stitch had cleared that same threshold when it's actually a distinct gate that hasn't been re-verified for this run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Graded capabilitygate by hand to Meta-Llama's and qwen2.5-coder's already-completed runs (no re-run needed — Phases C/D only changed scoring/gate logic, not B0-B3 answer generation).NoKvSlotstorm hit by two fresh Qwen3.5-9B full 120-question runs (both quants) on fully-fixed master — neither the SeqMax fix (§7b) nor the thinking-suppression fix (§7c) prevents it. This contradicts §7b's earlier "zero NoKvSlot, verified live" claim on the same code.Findings
Graded capabilitygate would PASS (B3 58 vs. best baseline B2 46), butReadyForExpansionstill fails overall onsegment_terminal_coverage(85.2%, blocking, target 1.0).Graded capabilitygate FAILS (B3 29 vs. B2 52) — same NO-GO the old all-or-nothing gate reached, now for the documented right reason.NoKvSlotincidents, permanent break on theReviewerrole after ~168 clean prior conversations, never recovers. B3 14/120 (worse than B2's 52/120) — void.Test plan
NoKvSlot/RECYCLINGpatterns and cross-checked against the gate JSON verdicts before writing any of this up.🤖 Generated with Claude Code
Summary by CodeRabbit
NoKvSlotstorm on the Reviewer role.NoKvSlotand related runtime gating issues.