-
Notifications
You must be signed in to change notification settings - Fork 0
Training Pit: toolcaller synthetic generator + Stage 1 target switcher #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
560b142
Training Pit: toolcaller synthetic generator + Stage 1 target switche…
hardcoreerik af84ae2
Add Claude API backend to toolcaller synthetic generator
hardcoreerik e50e986
Add native runtime backend for fully local toolcaller data generation
hardcoreerik 81f88db
Native runtime LoRA: convert toolcaller adapter + wire --lora support…
hardcoreerik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Static "→ Stage 2" badge doesn't reflect the new target picker.
This badge has no
x:Name, so it can never be updated whenCbGenTarget_SelectionChangedfires. Once the user selects "Toolcaller Examples → THE FOUNDRY", the output actually feeds Stage 3, but this badge still reads "→ Stage 2" — directly contradicting the PR's own goal of "route labels ... to distinguish the two data paths." TheTbGenTargetNotetext below is correctly updated, but this badge sits right in the header and will visibly conflict with it.🏷️ Proposed fix
Then update
GenRouteBadgeText.TextalongsideTbGenTargetNote.TextinsideCbGenTarget_SelectionChanged.📝 Committable suggestion
🤖 Prompt for AI Agents