Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side-effect of Microsoft bringing back support for pre-Windows 11 custom tooltips #96

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

AliveDevil
Copy link
Contributor

Using the WPF tooltip control for showing tool tip text feels out of place on Windows 11, as basic text based tooltips should be displayed using the NIF_SHOWTIP flag.

Fixes #95.

TrayToolTipResolved might be removable completely now.

@AliveDevil
Copy link
Contributor Author

Tested on

  • Windows 10 19045 - Uses the platform tooltip text, anchored to mouse pointer
  • Windows 11 22621 1265 - Uses the platform tooltip text, anchored above the task bar / tray flyout
  • Windows 11 22621 1343 - Uses the platform tooltip text, anchored above the task bar / tray flyout

Instead of:

  • Windows 10 - uses WPF tooltip
  • Windows 11 22621 1265 - uses the platform tooltip text, anchored above the task bar / tray flyout
  • Windows 11 22621 1343 - uses WPF tooltip

@ltjax
Copy link

ltjax commented Jul 6, 2023

This change works nicely for us. As a side effect, it also makes it possible to run our 'automation driven' tests again on Win 11 since the tooltip text shows up in the control's name (It only showed up in the tooltip before).

@markdavidoffosit
Copy link

@hardcodet @punker76 @Lakritzator Can we take a look at getting this merged and released?

@ChristophHornung
Copy link

ChristophHornung commented Apr 5, 2024

@AliveDevil @markdavidoffosit Did you get any feedback on the PR? Would really love to see it merged.

@markdavidoffosit
Copy link

@AliveDevil @markdavidoffosit Did you get any feedback on the PR? Would really love to see it merged.

Still waiting for this to be merged

@AliveDevil
Copy link
Contributor Author

@ChristophHornung

All communication here is public, in that sense, no, never received any feedback.

You could also just fork this repository, merge in my branch, and create a build for internal use - noone's stopping you from that.

@NotYoojun
Copy link

@AliveDevil @markdavidoffosit Did you get any feedback on the PR? Would really love to see it merged.

Hi there, sorry to bother. Our team has forked this repo for our internal uses and fixed some bugs. Also we welcome suggestions and PRs.

If you're interested, please contact [email protected], thanks!

@markdavidoffosit
Copy link

@punker76 Thanks for merging this fix!

@Emma1963
Copy link

Emma1963 commented Sep 5, 2024

@punker76 Thank you for merging this fix. Is there any plan for a new release NuGet?
It hasn't been released for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX discrepancy in latest Windows 11 22H2 Moment 2 (build 1343) with Tool Tip Text
7 participants