Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to set delay before component unmount #11

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Added ability to set delay before component unmount #11

merged 2 commits into from
Aug 31, 2017

Conversation

Fxlr8
Copy link
Contributor

@Fxlr8 Fxlr8 commented Aug 10, 2017

No description provided.

@Fxlr8
Copy link
Contributor Author

Fxlr8 commented Aug 10, 2017

#8

@nadyja
Copy link

nadyja commented Aug 23, 2017

I second this request

@haradakunihiko
Copy link
Owner

Thank you for the PR!
Can you add default value for unmountDelay with 1000? I do not want to change the default behavior and also, the variable should not be defined twice.

@Fxlr8
Copy link
Contributor Author

Fxlr8 commented Aug 30, 2017

done

@haradakunihiko haradakunihiko merged commit 8010e23 into haradakunihiko:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fxlr8 @nadyja @haradakunihiko