Conversation
Fixed query results not being added to QS
MKet
requested changes
Dec 11, 2025
Contributor
MKet
left a comment
MKet
left a comment
There was a problem hiding this comment.
I have some remarks for these code changes, please address them.
|
|
||
| var dataRow = dataTable.Rows[0]; | ||
| string result = null; | ||
| var dict = new Dictionary<string, string>(StringComparer.InvariantCultureIgnoreCase); |
Contributor
There was a problem hiding this comment.
Please give this dictionary a more descriptive name than dict. Something like queryResults or redirectResults is my suggestion.
| @@ -338,28 +360,14 @@ private async Task<string> RunRedirectQuery(Template template, QueryString query | |||
| throw new Exception($"Redirect query (id {template.Id}) returned {dataTable.Rows.Count} results, expected one!"); | |||
Contributor
There was a problem hiding this comment.
Since this method is being updated anyway please update this exception to something more appropriate.
My suggestion is using an InvalidOperationException
|
MKet
approved these changes
Dec 12, 2025
This was referenced Dec 18, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Using a redirect query to redirect to a new URL actually works now.
When using a redirect query to load a specific template, the other query columns are now added to the query string
Type of change
Please check only ONE option.
How was this tested?
Local build
Checklist before requesting a review
developas the base branch and notmain, or the pull request is a hotfix that needs to be done directly onmainRelated pull requests
n/a
Link to Asana ticket
https://app.asana.com/1/5038780173035/project/1204297502076149/task/1212343527813505