Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some dependencies and use travis templates #984

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 23, 2020

See the commit summary for more details. A few things to note:

  • There are still two dependencies that are out of date - globby and typescript. Updating them causes a number of test failures related to typescript, so I'll just leave that to someone else to fix.
  • The ESLint update is a major version bump, and there is potential for user facing changes (see the changes in test/). Does lab classify those linter changes as breaking changes? If so, we'll need to publish a new major version.

Commit summary:

update devDependency versions

This updates the devDependencies that were out of date.

update to eslint 7.x.x

This commit includes a bump in the eslint dependency, and the
following fixes related to it:

  • The line reported for no-unused-vars has changed. In this
    commit, a comment has been moved.
  • Starting with eslint 7, .eslintrc.js is no longer ignored by
    default. This required updating a test whose directory
    contains a .eslintrc.js file.
update to travis templates and test on node 14

cjihrig added 3 commits July 23, 2020 15:30
This commit includes a bump in the eslint dependency, and the
following fixes related to it:

- The line reported for no-unused-vars has changed. In this
  commit, a comment has been moved.
- Starting with eslint 7, .eslintrc.js is no longer ignored by
  default. This required updating a test whose directory
  contains a .eslintrc.js file.
@cjihrig cjihrig added dependency Update module dependency test Test or coverage labels Jul 23, 2020
@cjihrig cjihrig merged commit c3dd70a into hapijs:master Jul 29, 2020
@cjihrig cjihrig added the breaking changes Change that can breaking existing code label Jul 29, 2020
@cjihrig cjihrig mentioned this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code dependency Update module dependency test Test or coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants