fix: coverage for arrow functions returning literals

hapijs · Jul 27, 2024 · 801f15c · 801f15c
1 parent c306580
commit 801f15c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/lib/modules/coverage.js b/lib/modules/coverage.js
@@ -307,7 +307,7 @@ internals.instrument = function (filename, ctx) {
             node.set(`(global.__$$labCov._statement(\'${filename}\',${left},${line},${node.left.source()})${node.operator}global.__$$labCov._statement(\'${filename}\',${right},${line},${node.right.source()}))`);
         }
         else if (node.parent?.type === 'ArrowFunctionExpression' &&
-            node.type.includes('Expression')) {
+            (node.type.includes('Expression') || node.type === 'Literal')) {
 
             const id = addStatement(line, node, false);
 

diff --git a/test/coverage.js b/test/coverage.js
@@ -484,12 +484,13 @@ describe('Coverage', () => {
         results.push(Test.method11(5, 10));
         results.push(Test.method11(0, 10));
         results.push(Test.method11Partial(5, 10));
+        results.push(Test.method12());
 
         const cov = await Lab.coverage.analyze({ coveragePath: Path.join(__dirname, 'coverage/single-line-functions') });
         const source = cov.files[0].source;
         const missedLines = Object.keys(source).filter((lineNumber) => source[lineNumber].miss);
-        expect(results).to.equal([7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 5, 10, 5]);
-        expect(missedLines).to.equal(['12', '15', '21', '27', '30', '33', '39', '46', '50', '53', '56']);
+        expect(results).to.equal([7, 7, 7, 7, 7, 7, 7, 7, 7, 7, 5, 10, 5, 42]);
+        expect(missedLines).to.equal(['12', '15', '21', '27', '30', '33', '39', '46', '50', '53', '56', '59']);
     });
 
     it('should measure missing coverage on trailing function declarations correctly', async () => {

diff --git a/test/coverage/single-line-functions.js b/test/coverage/single-line-functions.js
@@ -54,3 +54,6 @@ exports.method10NotCalled = (a, b) => exports.method9NotCalled(a, b);
 
 exports.method11 = (a, b) => a || b;
 exports.method11Partial = (a, b) => a || b;
+
+exports.method12 = () => 42;
+exports.method12NotCalled = () => 42;