Allow 0x prefix for hex strings #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kindly take a look @Marsup |
|
Thanks for the PR. This feels like we should add an option (defaulting to false) to support this, otherwise I would consider it a breaking change. It would probably be more flexible anyway. |
BolajiOlajide
force-pushed
the
bo/allow-hex-with-prefix
branch
from
bd20d3a
to
32528e0
Compare
Updated! |
|
I'm going to do some changes before releasing it but it's already a good start, thanks a lot! |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2386
This PR updates the regex for validating hexadecimal. This allows hexes with the
0xprefix to be validated properly and those without to also pass validation provided they're valid hex strings.