Skip to content

Conversation

@WesTyler
Copy link
Contributor

I'm not sure if this is the simplest implementation here, but I took a stab.
Added the antithesis of string.regex as part of the invalid logic to support #1020.

@Marsup
Copy link
Collaborator

Marsup commented Nov 12, 2016

Oops, bad communication on my part, I should have provided more guidance. I don't want to change the valid/invalid api since it doesn't make sense, just allow for the regex to be inverted. So probably something like regex(pattern, [name | options]) that would still accept the old format but in addition accept an object with { name, reverse/invert/negative/... }. I can't make up my mind about the naming so if you have proposals.

@WesTyler
Copy link
Contributor Author

Oh, haha, gotcha. That makes more sense. Since it is a completely different direction I'll close this PR for clarity and make a new one later.

@WesTyler WesTyler closed this Nov 14, 2016
@Marsup Marsup added the feature New functionality or improvement label Nov 14, 2016
@Marsup Marsup self-assigned this Nov 14, 2016
@Marsup
Copy link
Collaborator

Marsup commented Nov 14, 2016

Shall I wait for you for v10 or you don't expect to work on it soon ?

@WesTyler
Copy link
Contributor Author

I'll have a new PR up later today if you want to wait for v10. :)

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants