Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add missing TS definition for options parameter in wait function #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Add missing TS definition for options parameter in wait function #387

wants to merge 1 commit into from

Conversation

damien-gl
Copy link

TS definition is currently missing the options parameter of wait function

@kanongil kanongil added the types TypeScript type definitions label Nov 28, 2023
kanongil
kanongil requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kanongil kanongil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options are not part of the public API.

If it has usage outside of Hoek itself, it can make sense to expose it, but the API docs needs to reflect this too.

Do you have any concrete usage examples, or did you just submit this for completeness sake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanongil kanongil kanongil requested changes

Assignees
No one assigned
Labels
types TypeScript type definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damien-gl @kanongil