Allow matching prereleases when validating plugin version requirements #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of node, hapi, and other plugins
devinivy
added
feature
…0+ w/ llhttp upgrade
Marsup
approved these changes
Jul 12, 2022
Nargonath
approved these changes
Jul 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically hapi has disallowed matching of prerelease versions when validating plugin
requirements. This has caused some issues, e.g. when node's CITGM runs hapi's test suite on upcoming versions of node (hapijs/somever#18), or when testing plugins against the beta of hapi v21 (hapijs/inert#164 (comment)). In hapijs/somever#18 we resolved to change this behavior within hapi. This PR addresses the issue, following from adding the feature to somever in hapijs/somever#22.I also updated the tests so that we don't trigger errors in the updated version of llhttp in node v18.5.0 (ref).