Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade production deps for hapi v21 and node v18 #4361

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented Jun 20, 2022

This updates all of hapi's production dependencies to the latest major versions, having dropped support for node v12 and added support for node v18.

Of note is one API change to hapi, where server.events.emit() may no longer be awaited due to changes in podium (though this is now supported through await server.events.gauge()). The server 'stop' and 'start' events also no longer are awaited during server start and stop: instead use server extension points such as onPreStart and onPostStop. Resolves #4184

If this looks good, we will publish this as hapi v21 beta 🎉 ! From there we will update test all hapi plugins and test them against the beta, then update the remaining hapi dev dependencies after the latest plugin versions are published 🎊

@devinivy devinivy added breaking changes Change that can breaking existing code dependency Update module dependency labels Jun 20, 2022
"@hapi/code": "9.0.0-beta.0",
"@hapi/eslint-plugin": "^5.0.0",
"@hapi/code": "^9.0.0",
"@hapi/eslint-plugin": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing though, I remember we set this dep to '*' with @Marsup in some plugins because we were having issues without it. Perhaps the underlying issue that was causing the behaviour has been fixed and I'm not up to date but I figured I might just voice it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The * is to keep it aligned with lab's version and not have to maintain it, I don't think this has changed, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory that makes perfect sense to me, but in practice this has been causing build failures. Here's a failed run for hapi v20 that can be fixed by specifying the eslint-plugin version: https://github.com/hapijs/hapi/runs/6866679357?check_suite_focus=true. These started failing once the next major of eslint-plugin was published.

@devinivy devinivy added this to the 21.0.0 milestone Jun 23, 2022
@devinivy devinivy self-assigned this Jun 23, 2022
@devinivy devinivy merged commit 0f8238d into v21 Jun 23, 2022
@Nargonath Nargonath deleted the v21-upgrade-deps branch June 24, 2022 07:09
@Nargonath
Copy link
Member

@devinivy I took the liberty to remove the source branch, feel free to restore if that's was a mistake.

@devinivy devinivy mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants