Fix handling of auth scheme/strategy realms #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Sep 5, 2021
devinivy
commented
Sep 5, 2021
geek
approved these changes
Sep 13, 2021
|
Thanks for taking care of this issue @devinivy! |
jonathansamines
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing some hard-to-explain behavior in #4218 as it relates to the realm of the
serverinside of auth schemes. In short, each timeserveris cloned, all servers were being mutated such thatserver.auth.strategywas bound to the server of the most recent clone.Cloning is the process by which hapi creates independent realms for a. each plugin and b. each auth strategy. When
serveris cloned, the clone'srealm.parentis assigned toserver.realm. Due to the mutation of a shared interface during each clone, theserver.realmwithin an auth strategy had a strange/unpredictable chain of ancestor realms. This work tidies that up by no longer mutating the sharedauthon each clone, instead creating a new public auth interface for each one.Resolves #4218.