-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future-proof hapi for node v16, rely on res close rather than req #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geek
approved these changes
Jan 25, 2021
Nargonath
approved these changes
Jan 26, 2021
Should we merge this @devinivy or is there something blocking it? |
lloydbenson
approved these changes
Mar 20, 2021
Now seems like a good time to land this. See also: nodejs/citgm#852 |
Does this mean that no versions of hapi older than v20.1.2 are compatible with Node 16? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in node v15.5.0 which broke hapi. We learned that this was considered a bug in node v15, but that a comparable change would land in node v16. As such, we now rely on res rather than req to handle premature
'close'
events. This small alteration should be compatible with node v12+, and is not considered a breaking change. This relies on a change within shot referenced below.Refs: #4208 hapijs/shot#139 nodejs/node#33035