Added support for brotli compression #3198
Conversation
|
The CI will fail as it depends on the changes done on Inert and Subtext. Not sure how to set it up. |
| @@ -2310,7 +2310,7 @@ following options: | |||
| clean up the files generated by the framework. This can be done by keeping track | |||
| of which files are used (e.g. using the `request.app` object), and listening to | |||
| the server `'response'` event to perform any needed cleanup. | |||
| - `parse` - can be `true`, `false`, or `gunzip`; determines if the incoming payload is | |||
| - `parse` - can be `true`, `false`, `gunzip`, or `br`; determines if the incoming payload is | |||
There was a problem hiding this comment.
below where we describe that true and gunzip will gunzip as appropriate, you should also mention that br is for brotli support. also why abbreviate it? brotli is plenty short IMO
There was a problem hiding this comment.
@nlf it seems that this will be added as a plugin but in any case I updated the API doc (not sure if the added text is the best / most comprehensible though).
Regarding the use of br (instead of brotli), it is the naming scheme that it is being used: google/brotli#299
There was a problem hiding this comment.
fair enough, silly decision on their part IMO, but if it's an established thing then we should probably stick with it
|
CI won't pass until the merges are done and published for your dependencies, you'll also have to update the shrinkwrap here to the correct versions |
|
This is blocked until I figure out how to move it to to a plugin. |
|
@nrotta You can now create a new plugin that simply calls |
|
FYI, I took some time and put together a plugin for this, currently unpublished here: https://github.com/kanongil/brok While it works, it would be much more useful if the |
|
(@kanongil why not |
|
@AdriVanHoudt agree |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Added support for brotli compression. The required changes to subtext and inert have also been done and the PRs submitted for merging.
This PR implements the following: #3037
PS: this PR was not sent from the master branch as I already have a PR on that branch waiting to be merged