Skip to content

Conversation

@tadgh
Copy link
Collaborator

@tadgh tadgh commented May 20, 2023

No description provided.

tadgh and others added 30 commits May 2, 2023 17:56
* fix RestHookTestR5IT

* fix intermittent

---------

Co-authored-by: Ken Stevens <[email protected]>
* Fix Oracle SQL error

* Add changelog
* Update clinical reasoning version

* Update version

* Update version

* Clean-up and more wireup of evaluationSettings

* Add changelog

---------

Co-authored-by: Jonathan Percival <[email protected]>
* Update the changelog for 4697 to be more descriptive

* Futher tweaks of the changelog
* Test, fix

* Drop constraint, add migration

* Add changelog

* Fix userSelected null vs false

* Fix merge

* Fix up checkstyle whining

* One more failure

* Fix test

* wip

* changelog clarity

Co-authored-by: James Agnew <[email protected]>

* change index

---------

Co-authored-by: Michael Buckley <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: leif stawnyczy <[email protected]>
* fix bug

* Favoring constructor initialization to autowiring.

* enhancing test.

* Making class LoggingEmailSender available outside of the hapi-fhir-japserver-uhnfhirtest module.

* Passing all tests.

* adding changelog.

* Bumping version to 6.5.20-SNAPSHOT

* addressing code review comment.

---------

Co-authored-by: peartree <[email protected]>
* Add docs for CR operations

* Correct changelog and javadoc for $package

* Add documentation for $apply parameters

* Add additional documentation for $package

* Cleanup

* Cleanup

* Cleanup

* Address review comments
* Add documentation for -gaps.

* addressing the comments.

---------

Co-authored-by: Chalma Maadaadi <[email protected]>
…splay defined in the codesystem 2 (#4854)

* added failing test

* implemented the solution

* changed test name

* added change log

* Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_6_0/4853-validation-does-not-error-when-display-is-not-the-same-as-the-display-defined-in-the-codesystem-2.yaml

Co-authored-by: James Agnew <[email protected]>

---------

Co-authored-by: Steven Li <[email protected]>
Co-authored-by: James Agnew <[email protected]>
* fixing patient everything operator

* review fix

---------

Co-authored-by: leif stawnyczy <[email protected]>
…ion will fail with HAPI-2207 (#4871)

* Add failing unit test.

* Fix JpaId Long equality comparison to use ! equals() instead of !=, which fails for different instances of the same Long value.

* Add changelog.
* added warn message and test

* code review fixes

---------

Co-authored-by: Long Ma <[email protected]>
* version bump for next release  (#4793)

* version bump

* Bump to correctnumber

* Version Enum and folder

* Remove interim from list

* wip

* Fix operation on nested type-choices in FhirPatch implementation (#4783)

* Fix operation on nested type-choices in FhirPatch implementation

* Add credit for #4783

---------

Co-authored-by: James Agnew <[email protected]>

* #4468 fix previous link offset no cache pagination (#4489)

* #4468 Add test reproducing the issue

* #4468 Fix previous link for no cache offset pagination

* #4468 Use unchecked URI parsing

* Credit for #4489

---------

Co-authored-by: James Agnew <[email protected]>

* Changelog and data generating test

* Add MdmLink index

* Avoid double link deletion

* Use ThreadLocal safely

---------

Co-authored-by: Tadgh <[email protected]>
Co-authored-by: Zach Smith <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Co-authored-by: Aleksej Parovysnik <[email protected]>
Co-authored-by: juan.marchionatto <[email protected]>
…LETE (#4859)

* Add failing unit test.

* Add conditional logic to the InstanceProgress progress percentage to disregard the incomplete count if this is called from the reduction step.  This is to get around a race condition in which a work chunk is QUEUED and not yet complete when the reduction step calculates the progress.

* Add final.

* Add changelog.
Co-authored-by: Ken Stevens <[email protected]>
* fixing some offset and adding a test

* fixing the offset paging

* Removing duplicate

---------

Co-authored-by: leif stawnyczy <[email protected]>
Co-authored-by: Aleksej Parovysnik <[email protected]>
…PREFIX-pointcut (#4876)

* Add failing test

* Add failing test

* Fix and changelog

* Pass content type parameter

* Back to auto wiring the context

* Invoke interceptor only when getting blobId, not also when storing it

* Avoid breaking implementers

* Address review comment

* Add new exception Msg code

* Fix broken test

---------

Co-authored-by: juan.marchionatto <[email protected]>
* Test, fix, and changelog

* Better partition resolution

* Add checks based on rule applier

* Fix ordering failure due to hash set

* Allow empty auth interceptor

* Fix up operation type on invocation

* Add more tests, make hack implementation for patient instance level operation

* Tighten test name

* Changelog

* Default method

* remove dead method

* Remove dead autowire

---------

Co-authored-by: Michael Buckley <[email protected]>
longma1 and others added 20 commits May 16, 2023 13:23
Co-authored-by: Long Ma <[email protected]>
* updating tests

* fixing bulk export to not fetch resources not requested

* cleanup

* cleanup

* more warning suppressing

* adding error code

* blah

* fix test

* review fixes

---------

Co-authored-by: leif stawnyczy <[email protected]>
* cve pom changes

* bump javax.el to jakarta.el

---------

Co-authored-by: Long Ma <[email protected]>
…rage preshow resources (#4906)

* Initial failing test

* Avoid applying binary blob id prefix multiple times

* Remove recently introduced method not needed anymore

---------

Co-authored-by: juan.marchionatto <[email protected]>
* repro bug with test, fix bug

* ken informed me he resolved this bug on master, so i'm switching to use his solution

* disable wars

* review feedback

* review feedback

* review feedback again

---------

Co-authored-by: josie <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
…t account for search parameters for custom resources types when converting dstu23 into runtimesearchparam (#4887)

* Modified canonicalizeSearchParameterDstu2 and 3, now correctly detect search parameters for custom resources

* Canonicalizers now correctly handle search parameters for custom resources

* created changelog

* Modification based on comments:
- remove Resource from target field when there are custom resource types
- fixed changelog typo
- removed unnecessary variable providesMembershipInCompartments

* Added tests for the SearchParameterCanonicalizer to test if base and target of RuntimeSearchParam is set as expected for DSTU2, DSTU3, R4, R4B, and R5 resources

* Fixed typo and removed commented code

* re-ordered init methods

* Update changelog

Co-authored-by: Tadgh <[email protected]>

* modifications following first code review.

---------

Co-authored-by: Tadgh <[email protected]>
Co-authored-by: peartree <[email protected]>
Remove _lastUpdated filtering of _revincludes.
* Remove all_constraints references which break in oracle 19c

* Add changelog

---------

Co-authored-by: juan.marchionatto <[email protected]>
* add check for empty fhirid string and add test

* add test for populateid

* changelog

* version bump

* version bump

* reverse version bump

* Back to 6.5.21-SNAPSHOT.

---------

Co-authored-by: justindar <[email protected]>
Co-authored-by: Luke deGruchy <[email protected]>
Use hash_identity for canonical join
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.82 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (043e575) 83.14%.

❗ Current head 043e575 differs from pull request most recent head 918208e. Consider uploading reports for the commit 918208e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4924      +/-   ##
============================================
+ Coverage     81.32%   83.14%   +1.82%     
- Complexity    23650    25432    +1782     
============================================
  Files          1425     1549     +124     
  Lines         86399    92756    +6357     
  Branches      11677    12361     +684     
============================================
+ Hits          70265    77125    +6860     
+ Misses        10947    10194     -753     
- Partials       5187     5437     +250     

see 1508 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tadgh tadgh merged commit 805e80e into master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.