Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading encrypted frames that don't line up with network frames #64

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

ccutrer
Copy link
Collaborator

@ccutrer ccutrer commented Feb 9, 2019

we want to call step again if there's remaining data. pos + toWrite
is what we consumed from this network frame to complete the encrypted
frame. so if it's less than the total network frame (data.length),
then call step again.

we want to call step again if there's remaining data. pos + toWrite
is what we consumed from this network frame to complete the encrypted
frame. so if it's less than the total network frame (data.length),
then call step again.
@timcharper
Copy link
Contributor

@beowulfe any chance you can grant me reviewing powers ? I'd like to give this a +1

@andylintner
Copy link
Collaborator

Thanks @ccutrer - this is a great fix! Could be the cause of a quite a few odd issues!

@timcharper - looks like I can't give granular permissions on a personal repo. But Inacknowledge your +1 :)

@andylintner andylintner merged commit e449fcf into hap-java:master Feb 11, 2019
@timcharper
Copy link
Contributor

I'm really rather wondering if the window covering bug was triggered with this! And removing the other characteristics caused it to stop triggering it.

It was failing in fantastic ways. Such a great fix!!!

@beowulfe do you feel like we're ready for a new point release? I'd like to start merging my openhab changes and integrating into master.

@ccutrer
Copy link
Collaborator Author

ccutrer commented Feb 14, 2019

I'd like to get ccutrer@1544779 (or some variation thereof) merged before a new point release. It was far easier to remove the LowBatteryStatusAccessory rather than trying to keep it compatible-but-deprecated. See #70.

@timcharper
Copy link
Contributor

I'll move the discussion there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants