Make pollHack work on read-only mounts on Darwin #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
adrianjagielak
added a commit
to adrianjagielak/go-fuse
that referenced
this pull request
Apr 5, 2022
Ports commit fee50bf to poll_darwin.go in order to allow read-only mounts on Darwin as well. Fixes rfjakob/gocryptfs#595 where we can't use gocryptfs -ro or gocryptfs -reverse on macOS because go-fuse tries to write to the read-only mountpoint during initial mount. Cheers! Edit: signed the CLA and re-pushed so automated checks pass Edit: potentially fixes hanwen#373 hanwen#420
|
could you send me a review through gerrithub? See https://github.com/hanwen/go-fuse/blob/master/CONTRIBUTING |
|
as this is open for a while now and a dealbreaker on OSX - maybe a little bump |
|
merged in 58a7e14 - can be closed |
|
Awesome, thanks for the bump and getting this patch though! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports commit fee50bf to
poll_darwin.goin order to allow read-only mounts on Darwin as well.Fixes rfjakob/gocryptfs#595 where we can't use
gocryptfs -roorgocryptfs -reverseon macOS because go-fuse tries to write to the read-only mountpoint during initial mount.Cheers!
Edit: signed the CLA and re-pushed so automated checks pass
Edit: potentially fixes #373