fix(Server): correct Content-Range implement

hans00 · Aug 3, 2022 · 7e37844 · 7e37844
1 parent 841c623
commit 7e37844
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/server/js/response.js b/packages/server/js/response.js
@@ -269,9 +269,9 @@ class Response extends Writable {
     if (Array.isArray(ranges) && ranges.length === 1 && ranges.type === 'bytes') {
       const [{ start, end }] = ranges
       if (this._totalSize && end <= this._totalSize) {
-        this._totalSize = end - start
         this.status(206)
           .setHeader('Content-Range', `bytes ${start}-${end}/${this._totalSize}`)
+        this._totalSize = end - start
         return stream.pipe(rangeStream(ranges)).pipe(this)
       }
     }

diff --git a/test/cases/http-pipe-file-stream-range.js b/test/cases/http-pipe-file-stream-range.js
@@ -13,7 +13,10 @@ module.exports = async function ({ HTTP_PORT }) {
     throw new Error('Unknown Content-Type')
   }
   if (Number(res.headers['content-length']) !== 4) {
-    throw new Error(`Invalid Content-Length ${res.headers['content-length']}`)
+    throw new Error(`Invalid Content-Length: ${res.headers['content-length']}`)
+  }
+  if (!['bytes 0-4/10', 'bytes 0-4/11'].includes(res.headers['content-range'])) {
+    throw new Error(`Invalid Content-Range: ${res.headers['content-range']}`)
   }
   if (res.data !== 'TEST') {
     throw new Error('Response data mismatch')