-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Mining Event Display Sorting #3117
base: beta
Are you sure you want to change the base?
Conversation
btw you dont need to close and open a new pr to push a second commit |
Yeah i,ve just been told. I'm new to contributing and pull requests and such |
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
2 similar comments
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
I have detected some issues with your pull request: Body issues: Please fix these issues. For the correct format, refer to the pull request template. |
ive updated the changelog verification so this issue should be easier to debug in the future (you had a random empty line which markdown removes) |
While |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/features/mining/eventtracker/MiningEventDisplay.kt
What
Changed mining island event display to sort Dwarven Mines first and then Crystal Hollows second
Changelog Improvements