Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Mining Event Display Sorting #3117

Open
wants to merge 6 commits into
base: beta
Choose a base branch
from

Conversation

penguin4life21
Copy link

@penguin4life21 penguin4life21 commented Dec 24, 2024

What

Changed mining island event display to sort Dwarven Mines first and then Crystal Hollows second

Changelog Improvements

  • Sorting mining islands in mining event. - Penguin4life

@NopoTheGamer
Copy link
Contributor

btw you dont need to close and open a new pr to push a second commit

@penguin4life21
Copy link
Author

Yeah i,ve just been told. I'm new to contributing and pull requests and such

@penguin4life21 penguin4life21 marked this pull request as ready for review December 24, 2024 20:51
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 24, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

2 similar comments
Copy link

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

Copy link

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 24, 2024
@CalMWolfs
Copy link
Collaborator

CalMWolfs commented Dec 24, 2024

ive updated the changelog verification so this issue should be easier to debug in the future (you had a random empty line which markdown removes)

@hannibal002
Copy link
Owner

While toSortedMap does work fine, I think using sortedBy with ordinal will be cleaner here

@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants