Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: TickEvent repeatSeconds Deprecation #3098

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Dec 20, 2024

What

I kinda feel like repeatSeconds should have its @Deprecation (oops, hi 👋) removed.
In some cases, like in the screenshot below the repeatSeconds event is better to look at.
image
In some rare cases using this is 100% better

The Ordanata/Larva changes might seem weird at first, but the main method alr ran every second, and the other variables had no other use cases so this should be fine.

Keeps the .repeatSeconds in the Reputation Helper since this one should be resolved by "removing" TablistUtils.getTablist()

Changelog Technical Details

  • Resolved some Deprecation in TickEvent.repeatSeconds(). - j10a1n15

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Dec 20, 2024
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 20, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 20, 2024
@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants