Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Sun Gecko Helper #3097

Open
wants to merge 17 commits into
base: beta
Choose a base branch
from

Conversation

NopoTheGamer
Copy link
Contributor

@NopoTheGamer NopoTheGamer commented Dec 20, 2024

What

Adds a sun gecko helper that shows your current combo and how long until you lose it

Images

image

image

image

I may have played a lot of gecko
image

Changelog New Features

  • Added Sun Gecko Helper. - nopo
    • Shows Health, Combo, Combo progress, how long until combo runs out, active modifiers.

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 20, 2024
Copy link

One or more Detekt Failures were detected:

@NopoTheGamer NopoTheGamer marked this pull request as ready for review December 21, 2024 00:20
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 21, 2024
Copy link

I have detected some issues with your pull request:

Body issues:
Change should start with 'Added' instead of 'Add' in text: Add Sun Gecko Helper.
Change should end with a full stop in text: Shows Health, Combo, Combo progress, how long until combo runs out, active modifiers

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 21, 2024
Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 21, 2024
Copy link
Contributor

@ItsEmpa ItsEmpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a review, apart from this there are some methods and vals that should be made private

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 21, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 21, 2024
for (line in event.full) {
if (line.startsWith(" Big damage in: §d")) {
modifiers.add(Modifiers.TIME_SLICED)
timeSliceDuration = TimeUtils.getDuration(line.replace(" Big damage in: §d", ""))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be done with a repopattern

@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants