Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Carrolyn #3096

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Feature: Carrolyn #3096

merged 4 commits into from
Dec 20, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Dec 20, 2024 •
edited
Loading

What

Carrolyn!

Images

image

Changelog New Features

  • Added Carrolyn Fetch Helper to fetch items for permanent farming buffs. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 20, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 20, 2024
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 20, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Helps to fetch items to Carrolyn for permanent buffs.- hannibal2

Title issues:
Unknown category: 'New Feature', valid categories are: Feature, Improvement, Fix, Backend, Remove and expected categories based on your changes are: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Helps to fetch items to Carrolyn for permanent buffs. - hannibal2

Title issues:
Unknown category: 'New Feature', valid categories are: Feature, Improvement, Fix, Backend, Remove and expected categories based on your changes are: Feature

Please fix these issues. For the correct format, refer to the pull request template.

@hannibal002 hannibal002 changed the title New Feature: Carrolyn Feature: Carrolyn Dec 20, 2024
@github-actions GitHub Actions
Copy link

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Helps to fetch items to Carrolyn for permanent buffs. - hannibal2

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 20, 2024
CalMWolfs
CalMWolfs approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@hannibal002 hannibal002 merged commit 82060fc into beta Dec 20, 2024
13 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.28
Development

Successfully merging this pull request may close these issues.
2 participants
@hannibal002 @CalMWolfs