Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: shtrackcollection not counting Youngite and Obsolite when tracking timite #3082

Merged

Conversation

martimavocado
Copy link
Contributor

@martimavocado martimavocado commented Dec 18, 2024

What

Describe what this pull request does, including technical details, screenshots, links to discord, etc.

Changelog Fixes

  • Fixed /shtrackcollection not tracking Youngite and Obsolite. - martimavocado

@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 18, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that this is the second special case for the collection tracker, maybe it could move this special logic to the repo
Something like:

"Cactus": [
"Cactus_green"
],
"Timite": [
"Youngite",
"Other ite"
]

@Thunderblade73
Copy link
Contributor

This can/should be a temporary fix. Since I'm currently completely replacing the logic with #2621. (Which I hope I complete before the end of the year)

@hannibal002
Copy link
Owner

hannibal002 commented Dec 18, 2024

I agree with Thunderblade here, using repo now will cause bigger merge conflicts. with the later pr /rewrite we also will move this into the repo with the format suggested by Cal.

@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 18, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 19, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 19, 2024
@hannibal002 hannibal002 merged commit 72103be into hannibal002:beta Dec 19, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants