-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: shtrackcollection not counting Youngite and Obsolite when tracking timite #3082
Fix: shtrackcollection not counting Youngite and Obsolite when tracking timite #3082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that this is the second special case for the collection tracker, maybe it could move this special logic to the repo
Something like:
"Cactus": [
"Cactus_green"
],
"Timite": [
"Youngite",
"Other ite"
]
This can/should be a temporary fix. Since I'm currently completely replacing the logic with #2621. (Which I hope I complete before the end of the year) |
I agree with Thunderblade here, using repo now will cause bigger merge conflicts. with the later pr /rewrite we also will move this into the repo with the format suggested by Cal. |
One or more Detekt Failures were detected:
|
What
Describe what this pull request does, including technical details, screenshots, links to discord, etc.
Changelog Fixes